[webkit-reviews] review granted: [Bug 76808] Web Inspector: Inspecting an element inside an iframe no longer works : [Attachment 123553] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 76808: Web Inspector: Inspecting an element inside an iframe no longer
works
https://bugs.webkit.org/show_bug.cgi?id=76808

Attachment 123553: Patch
https://bugs.webkit.org/attachment.cgi?id=123553&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123553&action=review


> Source/WebCore/inspector/front-end/DOMAgent.js:243
>	   }
> -
>	   DOMAgent.requestChildNodes(this.id, mycallback.bind(this));

I prefer empty lines line this. Otherwise it feels too crowded.

> Source/WebCore/inspector/front-end/DOMAgent.js:402
> +	   if (this._contentDocument)
> +	       return;

Maybe this deserves a comment? It needs to be this way because the children are
set in the constructor?