[webkit-reviews] review denied: [Bug 74687] [Qt] Incremental build problem revealed by r102981 : [Attachment 123550] proposed patch

[bugzilla-daemon at webkit.org]

Tor Arne Vestbø <vestbo at webkit.org> has denied Ádám Kallai
<Kallai.Adam at stud.u-szeged.hu>'s request for review:
Bug 74687: [Qt] Incremental build problem revealed by r102981
https://bugs.webkit.org/show_bug.cgi?id=74687

Attachment 123550: proposed patch
https://bugs.webkit.org/attachment.cgi?id=123550&action=review

------- Additional Comments from Tor Arne Vestbø <vestbo at webkit.org>
While the fix is correct it unfortunately doesn't solve the general problem,
for exxample is $$PWD/mathml/mathtags.in still left out of depends. And there's
a bunch of other generators that have the same problem.

The better approach I think would be to add code in default_post.prf that walks
every argument of commands and checks if it's a file that exists, and if so,
adds it to depends. That should ideally fix it for all of these cases.

Feel free to have a stab at it, or assign the bug to me and I'll have a look.
Thanks!