[webkit-reviews] review granted: [Bug 76793] [Qt] Implement SSL error handling QML API. : [Attachment 123462] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Alexander Færøy
<ahf at 0x90.dk>'s request for review:
Bug 76793: [Qt] Implement SSL error handling QML API.
https://bugs.webkit.org/show_bug.cgi?id=76793

Attachment 123462: Patch
https://bugs.webkit.org/attachment.cgi?id=123462&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123462&action=review


> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:500
> +bool QQuickWebViewPrivate::handleCertificateVerificationRequest(const
QString& hostname)
> +{
> +    if (!certificateVerificationDialog)
> +	   return false;
> +
> +    Q_Q(QQuickWebView);
> +    QtDialogRunner dialogRunner;
> +    if
(!dialogRunner.initForCertificateVerification(certificateVerificationDialog, q,
hostname))
> +	   return false;
> +
> +    setViewInAttachedProperties(dialogRunner.dialog());
> +
> +    disableMouseEvents();
> +    dialogRunner.exec();
> +    enableMouseEvents();
> +
> +    return dialogRunner.wasAccepted();
> +}

Just a thought, but is this boiler-plate code something that can be
centralized, either via a template or perhaps a macro?