[webkit-reviews] review denied: [Bug 76804] [chromium] PNG image with CMYK ICC color profile renders color-inverted and squashed : [Attachment 123517] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 23 01:30:54 PST 2012


Adam Barth <abarth at webkit.org> has denied noel gordon <noel.gordon at gmail.com>'s
request for review:
Bug 76804: [chromium] PNG image with CMYK ICC color profile renders
color-inverted and squashed
https://bugs.webkit.org/show_bug.cgi?id=76804

Attachment 123517: Patch
https://bugs.webkit.org/attachment.cgi?id=123517&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123517&action=review


> Source/WebCore/platform/image-decoders/png/PNGImageDecoder.cpp:233
> +// FIXME: color profile classification code was added in
https://bugs.webkit.org/show_bug.cgi?id=74400
> +// for JPEG images. Use that code here for now, but factor the code out into
some common place.

Can we do that in this patch?  It seems bad to have this copy/pasted code.


More information about the webkit-reviews mailing list