[webkit-reviews] review granted: [Bug 76690] WebKit fails IETC composition event types : [Attachment 123278] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 76690: WebKit fails IETC composition event types
https://bugs.webkit.org/show_bug.cgi?id=76690

Attachment 123278: Patch
https://bugs.webkit.org/attachment.cgi?id=123278&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123278&action=review


> Source/WebCore/ChangeLog:10
> +	   Other major browsers (Firefox and IE) don't populate the data
attribute  of the

Nit: two spaces between "attribute" and "of"

> Source/WebCore/ChangeLog:11
> +	   compositionstart event, but we set the given text in the data
attribute  to minimize the effect of this change.

Ditto. Also, isn't this line too long?

> Source/WebCore/editing/Editor.cpp:1460
> +	   //	 Send a compositionstart and a compositionupdate event when
this function creates a new composition node, i.e.

Looking at other lines, you should probably wrap the line earlier.