[webkit-reviews] review granted: [Bug 76310] Remove StackBounds from JSGlobalData : [Attachment 123398] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 22 14:09:45 PST 2012
Sam Weinig <sam at webkit.org> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 76310: Remove StackBounds from JSGlobalData
https://bugs.webkit.org/show_bug.cgi?id=76310
Attachment 123398: Patch
https://bugs.webkit.org/attachment.cgi?id=123398&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123398&action=review
> Source/JavaScriptCore/runtime/JSGlobalData.h:229
> const StackBounds& stack()
> {
> - return (globalDataType == Default)
> - ? m_stack
> - : wtfThreadData().stack();
> + return wtfThreadData().stack();
> }
It seems odd to keep this interface, if it no longer access JSGlobalData
members.
More information about the webkit-reviews
mailing list