[webkit-reviews] review requested: [Bug 76783] [GTK] Refactor GTK's accessibilitity code to be more modular : [Attachment 123450] Patch proposal

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 21 09:45:13 PST 2012


Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 76783: [GTK] Refactor GTK's accessibilitity code to be more modular
https://bugs.webkit.org/show_bug.cgi?id=76783

Attachment 123450: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=123450&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Now attaching the patch to "fix" this "issue".

As you can see the patch is huge, and does not contains any new test. The
reason for that, as you probably are already guessing, is that this patch
doesn't change any behavior compared to what is in trunk at the time of writing
this: it just moves code around to distribute it among different files, and
rename some things to maatch WK's coding style.

I checked it several times locally and it keeps passing all the tests (both API
and layout ones) so, combined with the fact that it didn't change anything,
makes it a safe patch, I think.

So, now asking for review. Thank you in advance!

PS: It would be nice to get this patch (if approved) integrated soon, so other
patches in the ATK code that might get in in the meanwhile don't make too hard
to keep this big patch up-to-date.


More information about the webkit-reviews mailing list