[webkit-reviews] review denied: [Bug 76559] SVG animation repaint issue with image and dynamic clipPath : [Attachment 123368] Patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has denied Kelly Norton
<knorton at google.com>'s request for review:
Bug 76559: SVG animation repaint issue with image and dynamic clipPath
https://bugs.webkit.org/show_bug.cgi?id=76559

Attachment 123368: Patch
https://bugs.webkit.org/attachment.cgi?id=123368&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123368&action=review


r- because of the test. Thanks for tackling this problem!

> Source/WebCore/rendering/svg/RenderSVGImage.h:44
> +    virtual void setNeedsBoundariesUpdate() { m_needsBoundariesUpdate =
true; }

Who is calling this? It's not clear from the patch, that this is the actual bug
fix :-)

> ChangeLog:8
> +	   * ManualTests/svg-repaint-image-clip-path.svg: Added.

A manual test should really be avoided here, it's too important to not
automatize it.
Can you look at creating a dynamic testcase?
I'd imagine doing this via a <script>, and a setTimeout(..., 0) - that should
be enough to trigger it, no?