[webkit-reviews] review granted: [Bug 76769] Web Inspector: Webkit2: attached Inspector height is not remembered : [Attachment 123437] Proposed Change

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 21 00:24:42 PST 2012


mitz at webkit.org has granted Timothy Hatcher <timothy at apple.com>'s request for
review:
Bug 76769: Web Inspector: Webkit2: attached Inspector height is not remembered
https://bugs.webkit.org/show_bug.cgi?id=76769

Attachment 123437: Proposed Change
https://bugs.webkit.org/attachment.cgi?id=123437&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=123437&action=review


> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:214
> +    [m_inspectorView.get() setFrame:NSMakeRect(NSMinX(inspectedViewFrame),
0.0, NSWidth(inspectedViewFrame),
inspectorPageGroup()->preferences()->inspectorAttachedHeight())];

Please change “0.0” to “0”.


More information about the webkit-reviews mailing list