[webkit-reviews] review granted: [Bug 76768] DFG should not have code that directly decodes the states of old JIT inline cache data structures : [Attachment 123431] the patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 76768: DFG should not have code that directly decodes the states of old JIT
inline cache data structures
https://bugs.webkit.org/show_bug.cgi?id=76768

Attachment 123431: the patch
https://bugs.webkit.org/attachment.cgi?id=123431&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123431&action=review


> Source/JavaScriptCore/bytecode/PutByIdStatus.h:44
> +	   NoInformation,
> +	   SimpleReplace,
> +	   SimpleTransition,
> +	   TakesSlowPath

Feed me comments like my brother!

> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:-1879
> -	       if (stubInfo.seen
> -		   &&
!m_inlineStackTop->m_profiledBlock->likelyToTakeSlowCase(m_currentIndex)
> -		   &&
!m_inlineStackTop->m_exitProfile.hasExitSite(m_currentIndex, BadCache)) {

You said this is a bugish thingy.