[webkit-reviews] review granted: [Bug 75521] Implement hardware accelerated Brightness and contrast filters : [Attachment 123420] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 75521: Implement hardware accelerated Brightness and contrast filters
https://bugs.webkit.org/show_bug.cgi?id=75521

Attachment 123420: Patch
https://bugs.webkit.org/attachment.cgi?id=123420&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123420&action=review


> Source/WebCore/ChangeLog:11
> +	   It also changes the spec for the brightness filter to be additive
rather than

Strictly speaking, it doesn't change the spec, but complies with suggested spec
changes.

> Source/WebCore/css/CSSParser.cpp:6815
> -	   // One optional argument, 0-1 or 0%-100%, if missing use 100%.
> +	   // One optional argument, 0-1 or 0%-100%, if missing use 100%,

The old version of the comments seems correct.

> Source/WebCore/css/CSSParser.cpp:6826
>	       // Saturate, Brightness and Contrast allow values over 100%.

Is this comment wrong now re: brightness?