[webkit-reviews] review granted: [Bug 74897] IndexedDB: Add tests for structured clone data : [Attachment 123210] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Joshua Bell <jsbell at chromium.org>'s
request for review:
Bug 74897: IndexedDB: Add tests for structured clone data
https://bugs.webkit.org/show_bug.cgi?id=74897

Attachment 123210: Patch
https://bugs.webkit.org/attachment.cgi?id=123210&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123210&action=review


> LayoutTests/platform/chromium/test_expectations.txt:3921
> +BUGWK74897 : storage/indexeddb/structured-clone.html = TEXT

You may want to file a new bug to track this since landing this patch will
close 74897.

>> LayoutTests/storage/indexeddb/structured-clone.html:16
>> +if (window.eventSender) {
> 
> What's this?	When is it available and not available?

It's like window.layoutTestController.	Checking it for existence is nice when
loading in a regular browser rather than DumpRenderTree.

> LayoutTests/storage/indexeddb/structured-clone.html:23
> +    eventSender.beginDragWithFiles(['resources/test-data.html',
'resources/test-data.txt']);
> +    eventSender.mouseMoveTo(targetX, targetY);
> +    eventSender.mouseUp();

Nit: Can you add some text (maybe to the description) that says that this test
requires DumpRenderTree?  Alternately you could write instructions on how to
run the test from a browser.