[webkit-reviews] review granted: [Bug 76723] Switch indexeddb to use supplemental IDL for DOMWindow : [Attachment 123418] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Mark Pilgrim (Google)
<pilgrim at chromium.org>'s request for review:
Bug 76723: Switch indexeddb to use supplemental IDL for DOMWindow
https://bugs.webkit.org/show_bug.cgi?id=76723

Attachment 123418: Patch
https://bugs.webkit.org/attachment.cgi?id=123418&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123418&action=review


> Source/WebCore/Modules/indexeddb/DOMWindowIndexedDatabase.cpp:62
> +	 
window->setIDBFactory(IDBFactory::create(page->group().idbFactory()));

I think this indent is off by one.

> Source/WebCore/page/DOMWindow.cpp:753
> +PassRefPtr<IDBFactory> DOMWindow::getIDBFactory()

Rather than returning a PassRefPtr<IDBFactory> here, we should just return a
raw pointer.  We use PassRefPtr when we're passing ownership of an object.