[webkit-reviews] review denied: [Bug 75732] [chromium] Add WebSolidColorLayer interface to draw non-textured color layers from Aura. : [Attachment 123342] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied W. James MacLean
<wjmaclean at chromium.org>'s request for review:
Bug 75732: [chromium] Add WebSolidColorLayer interface to draw non-textured
color layers from Aura.
https://bugs.webkit.org/show_bug.cgi?id=75732

Attachment 123342: Patch
https://bugs.webkit.org/attachment.cgi?id=123342&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123342&action=review


Nearly there!

> Source/WebCore/platform/graphics/chromium/cc/CCSolidColorLayerImpl.cpp:43
> +    , m_tileSize(256)

why is this a member variable if it's always the same? if it's a constant, make
it a constant

> Source/WebKit/chromium/tests/CCSolidColorLayerImplTest.cpp:42
> +// FIXME: The next three items have been borrowed from
CCTileLayerImplTest.cpp,
> +// but have more general applicability - move them into a something like
"CCLayerTestHelper.h/.cpp"?

could you just go ahead and do this?

> Source/WebKit/chromium/tests/CCSolidColorLayerImplTest.cpp:99
> +    layer->setBackgroundColor(0xFFA55AFF);

can you make this a named constant?

> Source/WebKit/chromium/tests/CCSolidColorLayerImplTest.cpp:106
> +    EXPECT_EQ(quadList.size(), 1U);
> +    if (!quadList.isEmpty())
> +	   EXPECT_EQ(quadList[0]->toSolidColorDrawQuad()->color(), 0xFFA55AFF);


if you're just worried about running off the end of the list if the quadList
doesn't have the expected size, then do this instead:

ASSERT_EQ(quadList.size(), 1u);
EXPECT_EQ(quadList[0]->....);

if the ASSERT_XXX() fails it'll immediately abort the test and not try to
continue