[webkit-reviews] review granted: [Bug 71529] [chromium] Write unit tests for compositor-thread zooming : [Attachment 123396] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 71529: [chromium] Write unit tests for compositor-thread zooming
https://bugs.webkit.org/show_bug.cgi?id=71529

Attachment 123396: Patch
https://bugs.webkit.org/attachment.cgi?id=123396&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123396&action=review


R=me

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:181
> +    const float minPageScale = 0.5f, maxPageScale = 4;

nit: webkit style is to define these sorts of literals as "0.5" without the
trailing "f"

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:219
> +	   float pageScaleDelta = 0.1f;

same here: WK style prefers "0.1"

> Source/WebKit/chromium/tests/CCLayerTreeHostImplTest.cpp:240
> +    const float minPageScale = 0.5f, maxPageScale = 4;

ditto