[webkit-reviews] review denied: [Bug 72672] [chromium] Incremental texture updates are not atomic : [Attachment 123378] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied David Reveman
<reveman at chromium.org>'s request for review:
Bug 72672: [chromium] Incremental texture updates are not atomic
https://bugs.webkit.org/show_bug.cgi?id=72672

Attachment 123378: Patch
https://bugs.webkit.org/attachment.cgi?id=123378&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123378&action=review


Very close, but tests need a bit of love still.

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:136
> +class CompositorFakeWebGraphicsContext3D : public FakeWebGraphicsContext3D {


how is this different from the one in CompositorFakeWebGraphicsContext3D.h? can
you use that one instead, or base this fake off of that fake to add the
additional functionality you need (like texture tracking)?

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:186
> +    vector<WebGLId> m_textures;
> +    set<WebGLId> m_usedTextures;

we don't use STL containers in WebKit, even in unit tests.  Use the WTF types