[webkit-reviews] review granted: [Bug 76680] run-perf-tests should support --test-results-server option : [Attachment 123249] Fixed per Dirk's comment

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 76680: run-perf-tests should support --test-results-server option
https://bugs.webkit.org/show_bug.cgi?id=76680

Attachment 123249: Fixed per Dirk's comment
https://bugs.webkit.org/attachment.cgi?id=123249&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123249&action=review


> Tools/Scripts/webkitpy/common/net/file_uploader.py:86
>  class FileUploader(object):

Were there no file_uploader unit tests to update?  If not, please add some
before landing.

> Tools/Scripts/webkitpy/common/net/file_uploader.py:92
> +    def upload_single_file(self, filesystem, content_type, filename):
> +	   self._upload_data(content_type, filesystem.read_text_file(filename))


upload_single_file -> upload_single_text_file ?

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:138
> +		   return -2

These numbers should probably be named constants.  Even better: just log the
problem rather than using error codes.