[webkit-reviews] review requested: [Bug 76657] [Qt] Fix the build with the newes Qt5 hashes : [Attachment 123350] proposed patch

[bugzilla-daemon at webkit.org]

Andras Becsi <abecsi at webkit.org> has asked  for review:
Bug 76657: [Qt] Fix the build with the newes Qt5 hashes
https://bugs.webkit.org/show_bug.cgi?id=76657

Attachment 123350: proposed patch
https://bugs.webkit.org/attachment.cgi?id=123350&action=review

------- Additional Comments from Andras Becsi <abecsi at webkit.org>
After a discussion with Tor Arne and Zeno the decision was to temporarily
disable the automatic touch->mouse synthesis in Qt to avoid the infinite loop
with QGuiApplicationPrivate::processTouchEvent and MiniBrowser's touch mocking.


After we make it possible to set the synthesized flag (which is currently
internally used to prevent infinite loops) on our touch mock events we can
enable it again and mark our touch events synthesized.

This decision was made because using QWindowSystemInterface::handleTouchEvent
to sent the mock events is the most straightforward solution.
If we would create the QTouchEvent's ourselves, we would need to set all the
positions and cache the last positions, which would result in more code and
would make the implementation more error prone to changes in
QQuickCanvasPrivate::translateTouchEvent and other places where touch points
are adjusted.