[webkit-reviews] review denied: [Bug 76110] Event Queue for HTMLMediaElement : [Attachment 123272] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has denied  review:
Bug 76110: Event Queue for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=76110

Attachment 123272: Patch
https://bugs.webkit.org/attachment.cgi?id=123272&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123272&action=review


Marking r- only because it fails to compile on ports that don't define
VIDEO_TRACK.

> Source/WebCore/html/MediaEventQueue.cpp:8
> +

Nit: This extra blank line is unnecessary.

> Source/WebCore/html/MediaEventQueue.cpp:70
> +    if (m_timer.isActive())

Nit: MediaEventQueue::close calls stop() without checking to see if the timer
is active, to be consistent you should one or the other throughout the file.
stop() is cheap so I would probably just call it but I don't have a strong
preference.