[webkit-reviews] review denied: [Bug 76685] Fix ASSERT Fail within AudioBus::processWithGainFrom : [Attachment 123254] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 20 09:11:10 PST 2012


Daniel Bates <dbates at webkit.org> has denied Raymond <rgbbones at gmail.com>'s
request for review:
Bug 76685: Fix ASSERT Fail within AudioBus::processWithGainFrom
https://bugs.webkit.org/show_bug.cgi?id=76685

Attachment 123254: Patch
https://bugs.webkit.org/attachment.cgi?id=123254&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123254&action=review


> Source/WebCore/ChangeLog:3
> +	   Fix ASSERT Fail within AudioBus::processWithGainFrom

Nit: Fail => fail

> Source/WebCore/ChangeLog:8
> +	   No new tests required.

Can you elaborate on why we can't write a test for this issue? The description
of this bug (comment #0) states that we may be able to use the page
<http://chromium.googlecode.com/svn/trunk/samples/audio/wavetable-synth.html>
to exhibit this assertion failure. Can we derive a test case from this page?


More information about the webkit-reviews mailing list