[webkit-reviews] review denied: [Bug 76464] Web Inspector: CopyText is not implemented for remote web inspector : [Attachment 123317] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 20 08:18:16 PST 2012
Pavel Feldman <pfeldman at chromium.org> has denied Konrad Piascik
<kpiascik at rim.com>'s request for review:
Bug 76464: Web Inspector: CopyText is not implemented for remote web inspector
https://bugs.webkit.org/show_bug.cgi?id=76464
Attachment 123317: patch
https://bugs.webkit.org/attachment.cgi?id=123317&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123317&action=review
You should also remove copyNode from the Inspector.json and
InspectorDOMAgent.h/cpp.
> Source/WebCore/inspector/front-end/ElementsTreeOutline.js:1687
> + var copy = function(id, text) {
Should be:
function copy(error, text)
{
if (!error)
....
}
More information about the webkit-reviews
mailing list