[webkit-reviews] review denied: [Bug 73309] [Qt] GC should be parallel on Qt platform : [Attachment 122934] This patch do the parallel gc only

[bugzilla-daemon at webkit.org]

Balazs Kelemen <kbalazs at webkit.org> has denied Roland Takacs
<Takacs.Roland at stud.u-szeged.hu>'s request for review:
Bug 73309: [Qt] GC should be parallel on Qt platform
https://bugs.webkit.org/show_bug.cgi?id=73309

Attachment 122934: This patch do the parallel gc only
https://bugs.webkit.org/attachment.cgi?id=122934&action=review

------- Additional Comments from Balazs Kelemen <kbalazs at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122934&action=review


I think we need yet another iteration.

> Source/JavaScriptCore/ChangeLog:25
> +	   * JavaScriptCore.order:
> +	   * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
> +	   * wtf/MainThread.cpp:
> +	   (WTF::initializeMainThread):
> +	   (WTF::registerGCThread):
> +	   (WTF::isMainThreadOrGCThread):
> +	   * wtf/MainThread.h:
> +	   * wtf/Platform.h:
> +	   * wtf/mac/MainThreadMac.mm:

Please examine what have you changed and why in a few words.

> Source/JavaScriptCore/wtf/MainThread.cpp:-92
> -
>  #if !PLATFORM(MAC)
> -

Again: why??? Zoltan already pointed out in his review that you should not make
such changes.

> Source/JavaScriptCore/wtf/MainThread.cpp:-107
> -
>  #else
> -

Ditto.