[webkit-reviews] review granted: [Bug 76428] Each style rule should have its own ID : [Attachment 123258] Patch 2

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 76428: Each style rule should have its own ID
https://bugs.webkit.org/show_bug.cgi?id=76428

Attachment 123258: Patch 2
https://bugs.webkit.org/attachment.cgi?id=123258&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123258&action=review


> Websites/webkit.org/coding/coding-style.html:233
> +<li id="linebreaking-multiple-satements">Each statement should get its own
line.

s/satements/statements/

> Websites/webkit.org/coding/coding-style.html:249
> +<li id="linebreaking-elese-braces">An <code>else</code> statement should go
on the same line as a preceding close brace if one is present,

s/elese/else/

> Websites/webkit.org/coding/coding-style.html:1104
> +    listItems[i].setAttribute('title', '#' + listItems[i].id);

May I get a hand as well so I can quick tell what is clickable? (I don't think
that is there just b/c you are listening for the click event.)

listItems[i].style.cursor = ' pointer';

> Websites/webkit.org/coding/coding-style.html:1107
> +    });

Perhaps it should check for duplicate ids as well?

Something like this:

var idsUsed = new Object();
for ...

  if (idsUsed[listItems[i].id])
     alert("The id " + listItems[i].id + " is used more than once in this
document.");
  idsUsed[listItems[i].id] = 1;