[webkit-reviews] review granted: [Bug 76682] Bytecode instructions that may have value profiling should have a direct inline link to the ValueProfile instance : [Attachment 123243] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 19:46:01 PST 2012


Sam Weinig <sam at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 76682: Bytecode instructions that may have value profiling should have a
direct inline link to the ValueProfile instance
https://bugs.webkit.org/show_bug.cgi?id=76682

Attachment 123243: the patch
https://bugs.webkit.org/attachment.cgi?id=123243&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123243&action=review


> Source/JavaScriptCore/dfg/DFGByteCodeParser.cpp:1745
>		   set(getInstruction[1].u.operand,
cellConstant(methodCall.cachedFunction.get()));
> +
>	       } else

Remove this weird newline.


More information about the webkit-reviews mailing list