[webkit-reviews] review granted: [Bug 76645] Dromaeo tests usage of StringImpl find routines cause 8->16 bit conversions : [Attachment 123163] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 15:59:10 PST 2012


Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 76645: Dromaeo tests usage of StringImpl find routines cause 8->16 bit
conversions
https://bugs.webkit.org/show_bug.cgi?id=76645

Attachment 123163: Patch
https://bugs.webkit.org/attachment.cgi?id=123163&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
I think you should factor out the shared hash-search code into a static helper
function template, to avoid code duplication.


More information about the webkit-reviews mailing list