[webkit-reviews] review granted: [Bug 76649] Dromaeo tests call parseSimpleLengthValue() on 8 bit strings : [Attachment 123203] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 15:56:40 PST 2012


Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 76649: Dromaeo tests call parseSimpleLengthValue() on 8 bit strings
https://bugs.webkit.org/show_bug.cgi?id=76649

Attachment 123203: Patch
https://bugs.webkit.org/attachment.cgi?id=123203&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
For simplicity, can this function just use StringImpl::operator[]? It only does
three derefs of the string, so using the characters pointer may not be
necessary.


More information about the webkit-reviews mailing list