[webkit-reviews] review granted: [Bug 76652] CaseFoldingHash::hash() doesn't handle 8 bit strings directly : [Attachment 123205] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <kling at webkit.org> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 76652: CaseFoldingHash::hash() doesn't handle 8 bit strings directly
https://bugs.webkit.org/show_bug.cgi?id=76652

Attachment 123205: Patch
https://bugs.webkit.org/attachment.cgi?id=123205&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123205&action=review


r=me, just one little thing:

> Source/JavaScriptCore/wtf/text/StringHash.h:105
>	       return hash(str->characters(), str->length());

You should switch this to characters16() to avoid the extra is8Bit() check in
StringImpl::characters().