[webkit-reviews] review granted: [Bug 74386] Migrate createObjectURL & revokeObjectURL to static (Class) methods : [Attachment 123078] Updated Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kaustubh Atrawalkar
<kaustubh at motorola.com>'s request for review:
Bug 74386: Migrate createObjectURL & revokeObjectURL to static (Class) methods
https://bugs.webkit.org/show_bug.cgi?id=74386

Attachment 123078: Updated Patch
https://bugs.webkit.org/attachment.cgi?id=123078&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123078&action=review


This looks good.  A few minor questions/nits below.  Thanks!

> Source/WebCore/html/DOMURL.cpp:-28
> -#if ENABLE(BLOB)

I'm curious why you moved this ifdef around.  It looks like almost everything
is ifdefed anyway.

> Source/WebCore/html/DOMURL.cpp:59
> +    virtual void contextDestroyed()

Please add the OVERRIDE keyword.  We're just starting to use that in WebKit.

> Source/WebCore/html/DOMURL.h:41
> +class DOMURL : public RefCounted<DOMURL> {

It looks like DOMURL is now declared outside of ENABLE(BLOB).  Is that what you
intend?