[webkit-reviews] review granted: [Bug 76635] Refactor canvas drawing to be more data driven : [Attachment 123191] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 19 14:15:13 PST 2012
James Robinson <jamesr at chromium.org> has granted Tim Dresser
<tdresser at chromium.org>'s request for review:
Bug 76635: Refactor canvas drawing to be more data driven
https://bugs.webkit.org/show_bug.cgi?id=76635
Attachment 123191: Patch
https://bugs.webkit.org/attachment.cgi?id=123191&action=review
------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123191&action=review
R=me, one nit
> Source/WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:685
> + drawTexturedQuad(quad->layerTransform(),
quad->quadRect().size().width(), quad->quadRect().size().height(),
quad->opacity(), sharedGeometryQuad(),
can I get a temporary const reference to size in this piece? this line's pretty
long, even by webkit standards
More information about the webkit-reviews
mailing list