[webkit-reviews] review denied: [Bug 76014] Web Intents chromium API modifications to track IntentRequest invocation method : [Attachment 123127] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Greg Billock
<gbillock at google.com>'s request for review:
Bug 76014: Web Intents chromium API modifications to track IntentRequest
invocation method
https://bugs.webkit.org/show_bug.cgi?id=76014

Attachment 123127: Patch
https://bugs.webkit.org/attachment.cgi?id=123127&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123127&action=review


> Source/WebKit/chromium/public/WebIntent.h:58
> +    WEBKIT_EXPORT bool equals(const WebIntent&);

nit: I think equals should be a const method.

> Source/WebKit/chromium/public/WebIntentRequest.h:61
> +    WEBKIT_EXPORT bool equals(const WebIntentRequest&);

nit: equals should be const

> Source/WebKit/chromium/src/WebIntentRequest.cpp:93
> +//	 RefPtr<WebCore::SerializedScriptValue> serializedValue = 

nit: delete commented out code

> Source/WebKit/chromium/src/WebIntentRequest.cpp:104
> +//	     (PassRefPtr<WebCore::SerializedScriptValue>)data;

nit: delete commented out code