[webkit-reviews] review granted: [Bug 76612] Some perf tests time out when ran by run-perf-tests : [Attachment 123099] fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 12:24:19 PST 2012


Eric Seidel <eric at webkit.org> has granted  review:
Bug 76612: Some perf tests time out when ran by run-perf-tests
https://bugs.webkit.org/show_bug.cgi?id=76612

Attachment 123099: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=123099&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123099&action=review


I think this is OK, after further discussion over IRC.

> Tools/Scripts/webkitpy/layout_tests/port/webkit.py:452
> +	   Driver.__init__(self, port, worker_number, pixel_tests, no_timeout)

I thought we got the "options" element off the port object?  (I'm not saying
that's necessarily a good thing,b ut I thought that was the status quo?)


More information about the webkit-reviews mailing list