[webkit-reviews] review granted: [Bug 76556] [Skia Mac] Match style of platform error underline for misspellings : [Attachment 122968] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 12:04:55 PST 2012


Stephen White <senorblanco at chromium.org> has granted Cary Clark
<caryclark at google.com>'s request for review:
Bug 76556: [Skia Mac] Match style of platform error underline for misspellings
https://bugs.webkit.org/show_bug.cgi?id=76556

Attachment 122968: Patch
https://bugs.webkit.org/attachment.cgi?id=122968&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122968&action=review


Looks good, assuming it passes the linter.  r=me

> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:659
> +#if PLATFORM(CHROMIUM) && OS(DARWIN)

Nit:  Probably don't need PLATFORM(CHROMIUM) here, but I see you've added it
elsewhere.


More information about the webkit-reviews mailing list