[webkit-reviews] review granted: [Bug 76035] Add state attribute to history's dom interface. : [Attachment 123150] review comments fixed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 11:12:04 PST 2012


Brady Eidson <beidson at apple.com> has granted Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 76035: Add state attribute to history's dom interface.
https://bugs.webkit.org/show_bug.cgi?id=76035

Attachment 123150: review comments fixed
https://bugs.webkit.org/attachment.cgi?id=123150&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123150&action=review


I would r+ now based on the premise that the comment is just obsolete and
accidentally left behind.  But we also need to answer Oliver's question.

>
LayoutTests/fast/loader/stateobjects/pushstate-state-attribute-only-one-deseria
lization.html:47
> +	   shouldBeTrue("event.state === history.state"); // This fails for
now, needs to be fixed.

Does this still fail or is this just an obsolete comment?


More information about the webkit-reviews mailing list