[webkit-reviews] review granted: [Bug 72589] [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs : [Attachment 123143] Patch Proposal

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 72589: [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based
ATs
https://bugs.webkit.org/show_bug.cgi?id=72589

Attachment 123143: Patch Proposal
https://bugs.webkit.org/attachment.cgi?id=123143&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123143&action=review


Looks good, but please make the following change before landing.

> Source/WebKit2/UIProcess/WebPageProxy.h:575
> +    String getAccessibilityPlugID() const { return m_accessibilityPlugID; }

In WebKit we typically don't use the getFoo naming scheme. Instead we just use
foo().