[webkit-reviews] review granted: [Bug 76634] [chromium] Replace WGC3D visibility extension with resource_usage extension. [Part 1 of 3] : [Attachment 123125] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 10:30:07 PST 2012


Kenneth Russell <kbr at google.com> has granted Michal Mocny
<mmocny at chromium.org>'s request for review:
Bug 76634: [chromium] Replace WGC3D visibility extension with resource_usage
extension. [Part 1 of 3]
https://bugs.webkit.org/show_bug.cgi?id=76634

Attachment 123125: Patch
https://bugs.webkit.org/attachment.cgi?id=123125&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Looks fine. In general, Chromium extensions added to WebGraphicsContext3D
should be mirrored in src/third_party/khronos/GLES2/gl2ext.h, and follow those
API conventions (meaning that OpenGL enum values would need to be assigned,
rather than using a local enum). However, since this is an API that is only
executed on the client side and isn't mirrored in the GL API, the structure
here is fine. r=me


More information about the webkit-reviews mailing list