[webkit-reviews] review granted: [Bug 74071] [Chromium] Chromium should have EditorClientImpl::checkTextOfParagraph : [Attachment 119809] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 10:12:48 PST 2012


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 74071: [Chromium] Chromium should have
EditorClientImpl::checkTextOfParagraph
https://bugs.webkit.org/show_bug.cgi?id=74071

Attachment 119809: Patch
https://bugs.webkit.org/attachment.cgi?id=119809&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=119809&action=review


> Source/WebKit/chromium/src/EditorClientImpl.cpp:770
> +					       WebCore::TextCheckingTypeMask
mask,

nit: no need to mention WebCore:: or WTF:: in this .cpp file.  notice the using
directive at the top of the file for WebCore, and the WTF headers have a using
directive.


More information about the webkit-reviews mailing list