[webkit-reviews] review requested: [Bug 76637] Update FloatRect::uniteIfNonZero to use isZero() : [Attachment 123135] Update uniteIfNonZero to use isZero

[bugzilla-daemon at webkit.org]

Philip Rogers <pdr at google.com> has asked  for review:
Bug 76637: Update FloatRect::uniteIfNonZero to use isZero()
https://bugs.webkit.org/show_bug.cgi?id=76637

Attachment 123135: Update uniteIfNonZero to use isZero
https://bugs.webkit.org/attachment.cgi?id=123135&action=review

------- Additional Comments from Philip Rogers <pdr at google.com>
A note on why I added no tests: I did a little research on what this change
will affect and I came up empty handed. I instrumented the code and ran all our
tests and visited various popular/complex pages, neither of which registered a
difference between the old behavior and the new. The primary use of
uniteIfNonZero in regular code is in RenderInline.cpp which, as far as I can
tell in my testing, only passes integer values through to this method and
should not be affected by this change. I still think this is change will be
clearly useful in preventing future bugs.