[webkit-reviews] review granted: [Bug 76532] Web Inspector: Implement screen resolution emulation backend : [Attachment 123131] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 19 08:26:27 PST 2012
Pavel Feldman <pfeldman at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 76532: Web Inspector: Implement screen resolution emulation backend
https://bugs.webkit.org/show_bug.cgi?id=76532
Attachment 123131: Patch
https://bugs.webkit.org/attachment.cgi?id=123131&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123131&action=review
Few nits, otherwise lgtm.
> Source/WebCore/inspector/InspectorPageAgent.cpp:289
> + if (m_originalFixedLayoutSize) {
nuke this code?
> Source/WebCore/inspector/InspectorPageAgent.cpp:621
> + notifyScreenSizeChanged();
Inline this into update.
More information about the webkit-reviews
mailing list