[webkit-reviews] review requested: [Bug 73922] [Qt] Public API watch dog auto test. : [Attachment 123107] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 19 04:43:08 PST 2012


Jocelyn Turcotte <jocelyn.turcotte at nokia.com> has asked  for review:
Bug 73922: [Qt] Public API watch dog auto test.
https://bugs.webkit.org/show_bug.cgi?id=73922

Attachment 123107: Patch
https://bugs.webkit.org/attachment.cgi?id=123107&action=review

------- Additional Comments from Jocelyn Turcotte <jocelyn.turcotte at nokia.com>
Updated the patch to work with the latest API.
A signal now contains a QWebNavigationRequest which wasn't possible to check
just with the root item.
The approach is now to manually keep a list of types to check and access their
::staticMetaObject directly.
Firing up a WebView in a QQuickView or accessing a QVariant value isn't
necessary anymore.
The semicolon style error is intentional to make copy-pasting the API in the
source file easier.


More information about the webkit-reviews mailing list