[webkit-reviews] review denied: [Bug 76593] Merge WebGraphicsContext3D creation and initialization : [Attachment 123045] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 18 18:08:26 PST 2012


Kenneth Russell <kbr at google.com> has denied Antoine Labour
<piman at chromium.org>'s request for review:
Bug 76593: Merge WebGraphicsContext3D creation and initialization
https://bugs.webkit.org/show_bug.cgi?id=76593

Attachment 123045: Patch
https://bugs.webkit.org/attachment.cgi?id=123045&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123045&action=review


This looks fine overall. Please request review again when you're ready to land
it. You might roll Source/WebKit/chromium/DEPS in the same patch.

> Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h:326
>      virtual WebGraphicsContext3D* createGraphicsContext3D() { return 0; }

Add a comment indicating that this variant is obsolete and is being removed.


More information about the webkit-reviews mailing list