[webkit-reviews] review canceled: [Bug 76560] Need a WebKit2 API for setting media volume : [Attachment 123026] Take 2: Make sure WebPageProxy caches the media volume value.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 18 17:50:15 PST 2012


Ada Chan <adachan at apple.com> has canceled Ada Chan <adachan at apple.com>'s
request for review:
Bug 76560: Need a WebKit2 API for setting media volume
https://bugs.webkit.org/show_bug.cgi?id=76560

Attachment 123026: Take 2: Make sure WebPageProxy caches the media volume
value.
https://bugs.webkit.org/attachment.cgi?id=123026&action=review

------- Additional Comments from Ada Chan <adachan at apple.com>
Two more fixes:
- Need to set the media volume with value from WebPageCreationParameters in
WebPage::WebPage().
- Need to set WebPageProxy::m_mediaVolume even if the associated WebPage is no
longer valid in the web process, since that updated value should be used when
the web process is relaunched.


More information about the webkit-reviews mailing list