[webkit-reviews] review granted: [Bug 76588] editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName : [Attachment 123040] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Enrica Casucci <enrica at apple.com>'s request for
review:
Bug 76588: editingAttributedStringFromRange in WebHTMLConverter does not handle
NSUnderlineStyleAttributeName
https://bugs.webkit.org/show_bug.cgi?id=76588

Attachment 123040: Patch
https://bugs.webkit.org/attachment.cgi?id=123040&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=123040&action=review


> Tools/TestWebKitAPI/Tests/mac/InspectorBar.mm:68
> +    NSDictionary *attributes = [attrString attributesAtIndex:0
effectiveRange:nil];

I think the effectiveRange parameter is a pointer to an NSRange, so you should
write 0, not nil.