[webkit-reviews] review granted: [Bug 75181] Implement a new allocator for backing stores : [Attachment 122346] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 75181: Implement a new allocator for backing stores
https://bugs.webkit.org/show_bug.cgi?id=75181

Attachment 122346: Patch
https://bugs.webkit.org/attachment.cgi?id=122346&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122346&action=review


R=me, but fix the issues.

> Source/JavaScriptCore/heap/ConservativeRoots.cpp:130
> +    genericAddSpan(begin, end, hook);

You should probably chain the dfgCodeBlocks mark hook below with the
PinStorageMarkHook.  Or better yet, kill the PinStorageMarkHook, and put the
pin storage logic directly into genericAddScan, since we need to do this all
the time anyway.

Otherwise you might get awesome fails where an array storage pointer was cached
across a heap allocation.

> Source/JavaScriptCore/wtf/Platform.h:-39
> -

You should probably revert Platform.h