[webkit-reviews] review denied: [Bug 76570] [WK2] Sync call for notifications permissions causes flashes on gmail.com : [Attachment 123017] [WK2] Sync call for notifications permissions causes flashes on gmail.com

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Jon Lee <jonlee at apple.com>'s request for
review:
Bug 76570: [WK2] Sync call for notifications permissions causes flashes on
gmail.com
https://bugs.webkit.org/show_bug.cgi?id=76570

Attachment 123017: [WK2] Sync call for notifications permissions causes flashes
on gmail.com
https://bugs.webkit.org/attachment.cgi?id=123017&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123017&action=review


> Source/WebKit2/UIProcess/API/C/WKNotificationManager.cpp:59
> +void
WKNotificationManagerProviderDidUpdateNotificationPolicy(WKNotificationManagerR
ef managerRef, WKStringRef originString, bool allowed)

We should be passing the origins as origins, not strings.

> Source/WebKit2/UIProcess/API/C/WKNotificationManager.cpp:64
> +void
WKNotificationManagerProviderDidRemoveNotificationPolicies(WKNotificationManage
rRef managerRef, WKArrayRef originStrings)

Same here.

> Source/WebKit2/UIProcess/Notifications/WebNotificationManagerProxy.cpp:175
> +    Vector<WTF::String> vectorOriginStrings;

Don't need the WTF::

> Source/WebKit2/WebProcess/Notifications/WebNotificationManager.cpp:79
> +    for (Vector<String>::const_iterator it = originStrings.begin(); it !=
originStrings.end(); ++it)

We usually iterate vectors using array style indexing.