[webkit-reviews] review granted: [Bug 76570] [WK2] Sync call for notifications permissions causes flashes on gmail.com : [Attachment 123016] [WK2] Sync call for notifications permissions causes flashes on gmail.com

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Jon Lee <jonlee at apple.com>'s
request for review:
Bug 76570: [WK2] Sync call for notifications permissions causes flashes on
gmail.com
https://bugs.webkit.org/show_bug.cgi?id=76570

Attachment 123016: [WK2] Sync call for notifications permissions causes flashes
on gmail.com
https://bugs.webkit.org/attachment.cgi?id=123016&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=123016&action=review


> Source/WebKit2/WebProcess/Notifications/WebNotificationManager.h:56
> +    void initialize(const HashMap<WTF::String, bool>& permissions);

No need for WTF:: here.

> Source/WebKit2/WebProcess/Notifications/WebNotificationManager.h:83
> +    typedef HashMap<WTF::String, bool> PermissionsMap;
> +    PermissionsMap m_permissionsMap;

No need for WTF:: here. Also, I don't think that the typedef is necessary here.