[webkit-reviews] review granted: [Bug 76570] [WK2] Sync call for notifications permissions causes flashes on gmail.com : [Attachment 123015] [WK2] Sync call for notifications permissions causes flashes on gmail.com

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 18 15:50:11 PST 2012


Sam Weinig <sam at webkit.org> has granted Jon Lee <jonlee at apple.com>'s request
for review:
Bug 76570: [WK2] Sync call for notifications permissions causes flashes on
gmail.com
https://bugs.webkit.org/show_bug.cgi?id=76570

Attachment 123015: [WK2] Sync call for notifications permissions causes flashes
on gmail.com
https://bugs.webkit.org/attachment.cgi?id=123015&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=123015&action=review


> Source/WebKit2/UIProcess/WebPageProxy.cpp:3309
> -    RefPtr<WebSecurityOrigin> origin =
WebSecurityOrigin::create(originIdentifier);
> +    RefPtr<WebSecurityOrigin> origin =
WebSecurityOrigin::createFromDatabaseIdentifier(originIdentifier);

Please put a comment here about how we probably should not be using database
identifier for geolocation.


More information about the webkit-reviews mailing list