[webkit-reviews] review granted: [Bug 76505] [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp : [Attachment 122992] move Tools/Tools.gyp to Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp, also change buildChromium()
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 18 14:20:34 PST 2012
Tony Chang <tony at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 76505: [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
https://bugs.webkit.org/show_bug.cgi?id=76505
Attachment 122992: move Tools/Tools.gyp to
Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp, also change
buildChromium()
https://bugs.webkit.org/attachment.cgi?id=122992&action=review
------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122992&action=review
Please watch the bots when landing.
> Tools/DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:37
> + # FIXME: Remove this conditional check once chromium's
> + # build/common.gypi is setting this flag to 0 by default. See
Weird indent.
More information about the webkit-reviews
mailing list