[webkit-reviews] review canceled: [Bug 76510] check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports : [Attachment 122858] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has canceled Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 76510: check-webkit-style of the chromium test_expectations.txt file
doesn't test all chromium ports
https://bugs.webkit.org/show_bug.cgi?id=76510

Attachment 122858: Patch
https://bugs.webkit.org/attachment.cgi?id=122858&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122858&action=review


>> Tools/Scripts/webkitpy/style/checkers/test_expectations.py:61
>> +			if "chromium" in name:
> 
> This doesn't seem like the right design.  Are we missing a concept here?

Yes. This patch is totally wrong. Will post a new one soon.