[webkit-reviews] review denied: [Bug 76560] Need a WebKit2 API for setting media volume : [Attachment 122974] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has denied Ada Chan <adachan at apple.com>'s request for review:
Bug 76560: Need a WebKit2 API for setting media volume
https://bugs.webkit.org/show_bug.cgi?id=76560

Attachment 122974: Patch
https://bugs.webkit.org/attachment.cgi?id=122974&action=review

------- Additional Comments from mitz at webkit.org
Like most settings on WKPage, this setting needs to persist even if  the Web
process crashes and gets relaunched. This means that you need to cache it in a
member variable in WebPagePorxy, and add it to WebPageCreationParameters and to
WebPageProxy::creationParameters() and the WebPage constructor. Having the
value cached in the WebPageProxy would also make it easy to add a getter on
WKPage in addition to the setter you’ve added.