[webkit-reviews] review granted: [Bug 76551] Cleanup: Move chrome-specific filesystem type handling code (for FileSystem API) under chromium directory : [Attachment 122953] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 18 13:29:10 PST 2012
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 76551: Cleanup: Move chrome-specific filesystem type handling code (for
FileSystem API) under chromium directory
https://bugs.webkit.org/show_bug.cgi?id=76551
Attachment 122953: Patch
https://bugs.webkit.org/attachment.cgi?id=122953&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122953&action=review
> Source/WebCore/platform/AsyncFileSystem.h:66
> + static const char kPersistentPathPrefix[];
I thought it was not WebKit style to use the kFoo naming scheme for constants.
Maybe you should not change it in this patch though as that would probably
bloat the patch too much.
More information about the webkit-reviews
mailing list